Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added whatsnew headers in JIRA issue #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added whatsnew headers in JIRA issue #259

wants to merge 2 commits into from

Conversation

gastaldi
Copy link

@gastaldi gastaldi commented Mar 25, 2015 •
edited
Loading

Needs some testing

This change is Reviewable

maxandersen
maxandersen reviewed Mar 25, 2015
View reviewed changes
whatsnew/createnewandnoteworthy.py
@@ -82,13 +82,14 @@ def quote(x):

cms = map(nametuple, comps)
#print name + "->" + str(cms)
new_file_contents = '= '+ name +' What\'s New\n:page-layout: whatsnew\n:page-component_id: '+comps+'\n:page-component_version: '+jbide_fixversion+'\n:page-product_id: jbt_core\n:page-product_version: '+jbide_fixversion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the idea, but component-fix version wont always be same as jbide fix version nor will the component id match perfectly ;/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add that info to the component array above?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you mean, maybe having a placeholder in the file contents instead?

@alexeykazakov
Copy link
Contributor 

File "createnewandnoteworthy.py", line 85, in <module>
    new_file_contents = '= '+ name +' What\'s New\n:page-layout: whatsnew\n:page-component_id: '+comps+'\n:page-component_version: '+jbide_fixversion+'\n:page-product_id: jbt_core\n:page-product_version: '+jbide_fixversion
TypeError: cannot concatenate 'str' and 'set' objects

@gastaldi
Copy link
Author

I confess I haven't tested it locally. I think it needs to call the join function?

Em 25/03/2015, às 21:08, Alexey Kazakov notifications@github.com escreveu:

File "createnewandnoteworthy.py", line 85, in
new_file_contents = '= '+ name +' What's New\n:page-layout: whatsnew\n:page-component_id: '+comps+'\n:page-component_version: '+jbide_fixversion+'\n:page-product_id: jbt_core\n:page-product_version: '+jbide_fixversion
TypeError: cannot concatenate 'str' and 'set' objects
—
Reply to this email directly or view it on GitHub.

@alexeykazakov
Copy link
Contributor

I guess so. But my python knowledge is very poor ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gastaldi @alexeykazakov @maxandersen